Open
Conversation
- Create docs/features/UPCOMING_EVENTS_README.md with user-facing guide - Add help preference in Navigation settings with in-app dialog - Add 'View Full Documentation' button to open GitHub docs - Create ic_help_outline_24dp drawable icon - Update docs/README.md with new Features section - Add string resources for help dialog and docs URL Co-authored-by: wharris <wharris@upscalews.com>
|
Cursor Agent can help with this pull request. Just |
williscool
changed the title
Code Coverage Report
|
📊 Code Coverage Summary
|
williscool
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| android:key="upcoming_events_help" | ||
| android:title="@string/upcoming_events_help_title" | ||
| android:summary="@string/upcoming_events_help_summary" | ||
| android:icon="@drawable/ic_help_outline_24dp" /> |
There was a problem hiding this comment.
Help preference visible when feature is disabled
Low Severity
The upcoming_events_help preference is always visible, even when the new navigation UI is disabled via the use_new_navigation_ui checkbox. The other Upcoming Events settings (lookahead mode, boundary hour, fixed hours) are correctly hidden when the feature is disabled because their parent PreferenceCategory has android:dependency="use_new_navigation_ui". The help preference lacks this dependency, so users see "Learn how the Upcoming tab works" even when there's no Upcoming tab.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add user-facing documentation for the Upcoming Events View and link it from the app's navigation settings.
Note
Adds an in-app help entry for the Upcoming tab and ships the corresponding user docs.
upcoming_events_helppreference innavigation_preferences.xmlwith help icon; click opens a dialog and deep-links to docs viaNavigationSettingsFragmentXic_help_outline_24dpdrawabledocs/features/UPCOMING_EVENTS_README.mdand link fromdocs/README.mdWritten by Cursor Bugbot for commit 28f868b. This will update automatically on new commits. Configure here.